Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integer parsing with unit support #1218

Merged
merged 2 commits into from
Jan 7, 2023
Merged

Add integer parsing with unit support #1218

merged 2 commits into from
Jan 7, 2023

Conversation

PragmaTwice
Copy link
Member

@PragmaTwice PragmaTwice commented Jan 7, 2023 •
edited
Loading

  • Add ParseSizeAndUnit
  • Clean some code

@PragmaTwice PragmaTwice marked this pull request as ready for review January 7, 2023 08:15
git-hulk
git-hulk previously approved these changes Jan 7, 2023
View reviewed changes
torwig
torwig reviewed Jan 7, 2023
View reviewed changes
src/common/parse_util.cc Outdated Show resolved Hide resolved
@PragmaTwice PragmaTwice requested review from git-hulk and torwig January 7, 2023 13:16
@tisonkun
Copy link
Member

tisonkun commented Jan 7, 2023

@PragmaTwice Could you please link the motivation of adding such a feature?

@PragmaTwice
Copy link
Member Author

PragmaTwice commented Jan 7, 2023 •
edited
Loading

@PragmaTwice Could you please link the motivation of adding such a feature?

It is needed in #953, and the implementation in #953 is not good to me so I do not want to refactor these code after merge it.

tisonkun
tisonkun approved these changes Jan 7, 2023
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging...

@tisonkun tisonkun merged commit 44ffb9a into apache:unstable Jan 7, 2023
@PragmaTwice PragmaTwice mentioned this pull request Jun 16, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@torwig torwig torwig approved these changes

@git-hulk git-hulk Awaiting requested review from git-hulk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PragmaTwice @tisonkun @git-hulk @torwig